Benchmark simplify operation #250
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds benchmarking capabilities for the symbolic model simplification operation. The changes introduce a new benchmark script and modify the model initialization to support timing measurements during the system simplification phase.
- Adds a dedicated benchmark script for measuring simplify operation performance
- Introduces a
benchparameter to control timing output during model initialization - Modifies system creation to suppress info messages during benchmarking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/bench_simplify.jl | New benchmark script that measures system simplification time |
| src/symbolic_awe_model.jl | Adds bench parameter and timing logic for simplify operation |
| src/mtk_model.jl | Modifies ODESystem creation to support bench mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1-Bart-1
left a comment
1-Bart-1
left a comment
There was a problem hiding this comment.
Why are you benchmarking this outdated version? Why not the SymbolicAWEModels.jl code? And a benchmark already exists there: SymbolicAWEModels.jl/test/bench.jl
|
Well, please review and approve this pull request. Or suggest changes I should make to this pull request. I already created a simular pull request in the other repository, but I do not want to finish that before you approved this pull request, because if you approved this one I would try to apply the same changes to the other pull request. Key properties of this benchmark:
|
Add bench_simplify.jl